Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve idempotency issue in SNMP Server user attribute handling #1014

Merged
merged 9 commits into from
Jan 31, 2024
Merged

Resolve idempotency issue in SNMP Server user attribute handling #1014

merged 9 commits into from
Jan 31, 2024

Conversation

roverflow
Copy link
Member

@roverflow roverflow commented Jan 18, 2024 •
edited
Loading

SUMMARY

The goal of this pull request is to address the issue in snmp server user attribute where the playbook on consecutive runs becomes idempotent, as passwords cannot be compared, this should not be happening, this pr aims to resolve that.

Some more context - issue

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME
  • ios_snmp_server.py

@codecov Codecov
Copy link

codecov bot commented Jan 18, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a961da9) 86.72% compared to head (af3c46d) 86.70%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1014      +/-   ##
==========================================
- Coverage   86.72%   86.70%   -0.02%     
==========================================
  Files         197      197              
  Lines       12075    12060      -15     
==========================================
- Hits        10472    10457      -15     
  Misses       1603     1603

see 2 files with indirect coverage changes

@roverflow roverflow added the bug This issue/PR relates to a bug. label Jan 18, 2024
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/64d30409be4a44c6a20a286ba8ae746d

✔️ ansible-galaxy-importer SUCCESS in 8m 40s
✔️ build-ansible-collection SUCCESS in 9m 49s
❌ ansible-ee-integration-ios-latest RETRY_LIMIT in 3m 27s (non-voting)
❌ ansible-ee-integration-ios-stable-2.9 FAILURE in 13m 12s (non-voting)
❌ ansible-ee-integration-ios-stable-2.11 RETRY_LIMIT in 3m 13s (non-voting)
❌ ansible-ee-integration-ios-stable-2.12 RETRY_LIMIT in 2m 52s (non-voting)
❌ ansible-ee-integration-ios-libssh-latest RETRY_LIMIT in 3m 27s (non-voting)
❌ ansible-ee-integration-ios-libssh-stable-2.9 FAILURE in 12m 48s (non-voting)
❌ ansible-ee-integration-ios-libssh-stable-2.11 RETRY_LIMIT in 3m 01s (non-voting)
❌ ansible-ee-integration-ios-libssh-stable-2.12 RETRY_LIMIT in 3m 17s (non-voting)
✔️ ansible-tox-linters SUCCESS in 11m 34s

@roverflow roverflow changed the title Fix snmp facts not rendering correctly Resolve Idempotency Issue in SNMP Server User Attribute Handling Jan 18, 2024
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/a175fd3751944f59bc708d0762166032

✔️ ansible-galaxy-importer SUCCESS in 4m 58s
✔️ build-ansible-collection SUCCESS in 9m 46s
❌ ansible-ee-integration-ios-latest RETRY_LIMIT in 3m 52s (non-voting)
❌ ansible-ee-integration-ios-stable-2.9 FAILURE in 12m 37s (non-voting)
❌ ansible-ee-integration-ios-stable-2.11 RETRY_LIMIT in 3m 44s (non-voting)
❌ ansible-ee-integration-ios-stable-2.12 RETRY_LIMIT in 3m 47s (non-voting)
❌ ansible-ee-integration-ios-libssh-latest RETRY_LIMIT in 3m 40s (non-voting)
❌ ansible-ee-integration-ios-libssh-stable-2.9 FAILURE in 13m 29s (non-voting)
❌ ansible-ee-integration-ios-libssh-stable-2.11 RETRY_LIMIT in 2m 53s (non-voting)
❌ ansible-ee-integration-ios-libssh-stable-2.12 RETRY_LIMIT in 3m 03s (non-voting)
✔️ ansible-tox-linters SUCCESS in 11m 33s

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/ac631a3970ee416a8c219e2d229df2b0

✔️ ansible-galaxy-importer SUCCESS in 4m 54s
✔️ build-ansible-collection SUCCESS in 9m 43s
❌ ansible-ee-integration-ios-latest RETRY_LIMIT in 3m 22s (non-voting)
❌ ansible-ee-integration-ios-stable-2.9 FAILURE in 12m 59s (non-voting)
❌ ansible-ee-integration-ios-stable-2.11 RETRY_LIMIT in 3m 09s (non-voting)
❌ ansible-ee-integration-ios-stable-2.12 RETRY_LIMIT in 3m 13s (non-voting)
❌ ansible-ee-integration-ios-libssh-latest RETRY_LIMIT in 3m 07s (non-voting)
❌ ansible-ee-integration-ios-libssh-stable-2.9 FAILURE in 13m 30s (non-voting)
❌ ansible-ee-integration-ios-libssh-stable-2.11 RETRY_LIMIT in 3m 21s (non-voting)
❌ ansible-ee-integration-ios-libssh-stable-2.12 RETRY_LIMIT in 3m 25s (non-voting)
✔️ ansible-tox-linters SUCCESS in 11m 40s

@roverflow roverflow changed the title Resolve Idempotency Issue in SNMP Server User Attribute Handling Resolve idempotency issue in SNMP Server user attribute handling Jan 25, 2024
@roverflow roverflow linked an issue Jan 30, 2024 that may be closed by this pull request
ios_snmp_server readonly community idempotency #971
Open
@roverflow roverflow removed a link to an issue Jan 30, 2024
ios_snmp_server readonly community idempotency #971
Open
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/6e458495f48e436f98762a73fad37f03

✔️ ansible-galaxy-importer SUCCESS in 4m 38s
✔️ build-ansible-collection SUCCESS in 10m 06s
❌ ansible-ee-integration-ios-latest RETRY_LIMIT in 3m 20s (non-voting)
❌ ansible-ee-integration-ios-stable-2.9 FAILURE in 14m 47s (non-voting)
❌ ansible-ee-integration-ios-stable-2.11 RETRY_LIMIT in 3m 13s (non-voting)
❌ ansible-ee-integration-ios-stable-2.12 RETRY_LIMIT in 4m 02s (non-voting)
❌ ansible-ee-integration-ios-libssh-latest RETRY_LIMIT in 3m 46s (non-voting)
❌ ansible-ee-integration-ios-libssh-stable-2.9 FAILURE in 12m 57s (non-voting)
❌ ansible-ee-integration-ios-libssh-stable-2.11 RETRY_LIMIT in 3m 18s (non-voting)
❌ ansible-ee-integration-ios-libssh-stable-2.12 RETRY_LIMIT in 3m 02s (non-voting)
✔️ ansible-tox-linters SUCCESS in 11m 55s

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/c8757043e0ca49a585c8bf3ed8bf9289

✔️ ansible-galaxy-importer SUCCESS in 3m 30s
✔️ build-ansible-collection SUCCESS in 10m 39s
❌ ansible-ee-integration-ios-latest RETRY_LIMIT in 3m 08s (non-voting)
❌ ansible-ee-integration-ios-stable-2.9 FAILURE in 12m 36s (non-voting)
❌ ansible-ee-integration-ios-stable-2.11 RETRY_LIMIT in 3m 19s (non-voting)
❌ ansible-ee-integration-ios-stable-2.12 RETRY_LIMIT in 3m 24s (non-voting)
❌ ansible-ee-integration-ios-libssh-latest RETRY_LIMIT in 3m 14s (non-voting)
❌ ansible-ee-integration-ios-libssh-stable-2.9 FAILURE in 12m 06s (non-voting)
❌ ansible-ee-integration-ios-libssh-stable-2.11 RETRY_LIMIT in 3m 17s (non-voting)
❌ ansible-ee-integration-ios-libssh-stable-2.12 RETRY_LIMIT in 3m 15s (non-voting)
✔️ ansible-tox-linters SUCCESS in 11m 30s

@KB-perByte KB-perByte merged commit d629cc6 into ansible-collections:main Jan 31, 2024
55 checks passed
@roverflow roverflow deleted the snmp_idempotancy_fix branch May 8, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NilashishC NilashishC NilashishC left review comments

@KB-perByte KB-perByte KB-perByte approved these changes

Assignees
No one assigned
Labels
bug This issue/PR relates to a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@roverflow @NilashishC @KB-perByte